Conversation
campos20
force-pushed
the
feature/add-vite
branch
from
a03ee94 to
dd6f847
Compare
There was a problem hiding this comment.
Why are you dropping some of the instructions here without any replacement?
There was a problem hiding this comment.
To run the FE only, we are pointing to the prod version. So, it is very simple to run npm install and then npm start. The whole docker setup needed a lot of adjustments about the database dump. Do you think it is still worth it? I can put it back and adjust the Dockerfile to use vite.
| "typescript": "^4.1.2", | ||
| "web-vitals": "^1.0.1" | ||
| }, | ||
| "version": "0.0.0", |
There was a problem hiding this comment.
Why reset to 0.0.0 if it was 0.1.0
There was a problem hiding this comment.
Vite again. Also, this is not used.
| @@ -1,7 +1,7 @@ | |||
| export default interface Result { | |||
| end: Date; | |||
| end: string; | |||
| end: string; | ||
| rank: number; | ||
| start: Date; | ||
| start: string; |
There was a problem hiding this comment.
Just making typescript happy. Also, this is display only.
There was a problem hiding this comment.
Why is this entirely commented out?
There was a problem hiding this comment.
Because it is not currently working. We need to add vitest and make some adjustments.
There was a problem hiding this comment.
Why are you deleting the whole Docker Compose setup?
Does Vite not support running with Docker?!
There was a problem hiding this comment.
Vite supports it. Same as above about docker.
2 participants
No functionality change.
Actually, just a small functionality change. We don't rely on the BE anymore to get the redirect URI. This will probably speed up login time.